[master] 0959f3559 backend: Assume TX_ERROR by default for pipe

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Wed Jan 31 21:44:07 UTC 2024


commit 0959f3559647fbb950d3b97d8f0dd8cb10101ca5
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Wed Jan 31 22:39:54 2024 +0100

    backend: Assume TX_ERROR by default for pipe

diff --git a/bin/varnishd/cache/cache_backend.c b/bin/varnishd/cache/cache_backend.c
index c24ae96a2..61be0aa27 100644
--- a/bin/varnishd/cache/cache_backend.c
+++ b/bin/varnishd/cache/cache_backend.c
@@ -382,11 +382,10 @@ vbe_dir_http1pipe(VRT_CTX, VCL_BACKEND d)
 
 	ctx->req->res_mode = RES_PIPE;
 
+	retval = SC_TX_ERROR;
 	pfd = vbe_dir_getfd(ctx, ctx->req->wrk, d, bp, 0);
 
-	if (pfd == NULL) {
-		retval = SC_TX_ERROR;
-	} else {
+	if (pfd != NULL) {
 		CHECK_OBJ_NOTNULL(ctx->bo->htc, HTTP_CONN_MAGIC);
 		i = V1F_SendReq(ctx->req->wrk, ctx->bo,
 		    &v1a.bereq, &v1a.out);


More information about the varnish-commit mailing list