[master] bdc32bea8 param: Show bits parameters as absolute values
Dridi Boukelmoune
dridi.boukelmoune at gmail.com
Tue Nov 21 06:03:09 UTC 2023
commit bdc32bea807ff8eb954a3783a5e62ae9396b410b
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date: Tue Nov 7 07:58:19 2023 +0100
param: Show bits parameters as absolute values
diff --git a/bin/varnishd/mgt/mgt_param_tweak.c b/bin/varnishd/mgt/mgt_param_tweak.c
index f1ac4d4b5..82a1e192a 100644
--- a/bin/varnishd/mgt/mgt_param_tweak.c
+++ b/bin/varnishd/mgt/mgt_param_tweak.c
@@ -675,7 +675,6 @@ tweak_generic_bits(struct vsb *vsb, const struct parspec *par, const char *arg,
uint8_t *p, unsigned l, const char * const *tags, const char *desc,
char sign)
{
- const char *s;
unsigned j;
if (arg != NULL && !strcmp(arg, "default") &&
@@ -690,15 +689,11 @@ tweak_generic_bits(struct vsb *vsb, const struct parspec *par, const char *arg,
if (arg == JSON_FMT)
VSB_putc(vsb, '"');
- s = "";
+ VSB_cat(vsb, sign == '+' ? "none" : "all");
for (j = 0; j < l; j++) {
- if (bit(p, j, BTST)) {
- VSB_printf(vsb, "%s%c%s", s, sign, tags[j]);
- s = ",";
- }
+ if (bit(p, j, BTST))
+ VSB_printf(vsb, ",%c%s", sign, tags[j]);
}
- if (*s == '\0')
- VSB_cat(vsb, sign == '+' ? "none" : "all");
if (arg == JSON_FMT)
VSB_putc(vsb, '"');
return (0);
More information about the varnish-commit
mailing list