[master] 3f67c2d37 vtc: Disable c124

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Mon Jul 10 13:05:07 UTC 2023


commit 3f67c2d37739132952175047aae6dbe7f0144486
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Mon Jul 10 08:11:53 2023 +0200

    vtc: Disable c124

diff --git a/bin/varnishtest/tests/c00124.vtc b/bin/varnishtest/tests/c00124.vtc.disabled
similarity index 89%
rename from bin/varnishtest/tests/c00124.vtc
rename to bin/varnishtest/tests/c00124.vtc.disabled
index 2da09f139..898d678e3 100644
--- a/bin/varnishtest/tests/c00124.vtc
+++ b/bin/varnishtest/tests/c00124.vtc.disabled
@@ -1,5 +1,9 @@
 varnishtest "rushed task queued"
 
+# this does not work reliably because the acceptor task may
+# be queued during the child startup if not all threads are
+# created
+
 # thread reserve mitigation barrier
 barrier b0 sock 2
 
@@ -61,12 +65,14 @@ varnish v1 -expect threads == 5
 client c1 {
 	txreq -hdr "Cookie: foo" -hdr "server: s1"
 	rxresp
+	expect resp.status == 200
 } -start
 
 # 2 threads
 client c2 {
 	txreq -hdr "server: s2"
 	rxresp
+	expect resp.status == 200
 } -start
 
 # ensure c1 and c2 fetch tasks are started
@@ -84,11 +90,11 @@ varnish v1 -expect sess_dropped == 0
 varnish v1 -expect sess_queued == 0
 
 # At this point, we are thread-starved and c3 below will steal the
-# acceptor thread. It will be queued before the acceptor task queues
-# itself with a lower priority.
+# acceptor thread that will queue itself.
 client c3 {
 	txreq
 	rxresp
+	expect resp.status == 200
 } -start
 
 logexpect l1 -wait


More information about the varnish-commit mailing list