[master] 57cbd8450 varnishtest: Remove redundant WRONGs

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Fri May 28 09:28:05 UTC 2021


commit 57cbd8450682336196ccc3c5433e0b4829474d47
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Fri May 28 11:26:07 2021 +0200

    varnishtest: Remove redundant WRONGs
    
    A wrong WRONG doesn't make it right for SunCC.

diff --git a/bin/varnishtest/vtc_tunnel.c b/bin/varnishtest/vtc_tunnel.c
index 4f6f24c7b..231fcc919 100644
--- a/bin/varnishtest/vtc_tunnel.c
+++ b/bin/varnishtest/vtc_tunnel.c
@@ -192,7 +192,6 @@ cmd_tunnel_pause(CMD_ARGS)
 	if (t->state == TUNNEL_PAUSED) {
 		AZ(pthread_mutex_unlock(&t->mtx));
 		vtc_fatal(vl, "Tunnel already paused");
-		WRONG("unreachable");
 	}
 	assert(t->state == TUNNEL_RUNNING);
 	t->state = TUNNEL_PAUSED;
@@ -230,7 +229,6 @@ cmd_tunnel_send(CMD_ARGS)
 	if (t->state == TUNNEL_RUNNING) {
 		AZ(pthread_mutex_unlock(&t->mtx));
 		vtc_fatal(vl, "Tunnel still running");
-		WRONG("unreachable");
 	}
 	assert(t->state == TUNNEL_PAUSED);
 	AZ(t->send_lane->wrk_len);
@@ -285,7 +283,6 @@ cmd_tunnel_resume(CMD_ARGS)
 	if (t->state == TUNNEL_RUNNING) {
 		AZ(pthread_mutex_unlock(&t->mtx));
 		vtc_fatal(vl, "Tunnel already running");
-		WRONG("unreachable");
 	}
 	assert(t->state == TUNNEL_PAUSED);
 	t->state = TUNNEL_RUNNING;


More information about the varnish-commit mailing list