[master] 0632b8469 req: Prevent early rollback

[Dridi Boukelmoune]

commit 0632b84693f3e146b7208e5310bc59b0e2769296
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Tue Jul 13 07:50:05 2021 +0200

    req: Prevent early rollback
    
    After a cleanup we may still use the request's workspace, so the final
    rollback should instead happen at release time before we give the memory
    back to the pool.

diff --git a/bin/varnishd/cache/cache_req.c b/bin/varnishd/cache/cache_req.c
index e2981e69b..eeb339b62 100644
--- a/bin/varnishd/cache/cache_req.c
+++ b/bin/varnishd/cache/cache_req.c
@@ -172,6 +172,7 @@ Req_Release(struct req *req)
 	AZ(req->vcl);
 	if (req->vsl->wid)
 		VSL_End(req->vsl);
+	WS_Rollback(req->ws, 0);
 	TAKE_OBJ_NOTNULL(sp, &req->sp, SESS_MAGIC);
 	pp = sp->pool;
 	CHECK_OBJ_NOTNULL(pp, POOL_MAGIC);
@@ -261,7 +262,9 @@ Req_Cleanup(struct sess *sp, struct worker *wrk, struct req *req)
 	if (WS_Overflowed(req->ws))
 		wrk->stats->ws_client_overflow++;
 
-	WS_Rollback(req->ws, 0);
+	/* no snapshot for h2 stream 0 */
+	if (req->ws_req)
+		WS_Rollback(req->ws, req->ws_req);
 }
 
 /*----------------------------------------------------------------------