[master] f44f16cc4 Revert "disable -Wcast-qual because of musl"

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Mon Apr 12 13:14:05 UTC 2021


commit f44f16cc4696e9e7f434dfd6d67b4e0447b4e97b
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Mon Apr 12 15:09:13 2021 +0200

    Revert "disable -Wcast-qual because of musl"
    
    This reverts commit 05780b634c40233dd2494a2c76a8dd8ba72d79f8.
    
    If we have to choose between this warning and alpine being part of our
    CI, this warning takes precedence. It's always possible to disable
    developer warnings on CCI if that's a problem with musl then we can
    configure its CCI job to disable developer warnings.
    
    Reopens #3565
    Refs #3568

diff --git a/wflags.py b/wflags.py
index 7e4d30fed..d060d1794 100644
--- a/wflags.py
+++ b/wflags.py
@@ -44,6 +44,7 @@ DESIRABLE_OPTIONS = [
 
 DESIRABLE_WFLAGS = [
     "-Wcast-align",
+    "-Wcast-qual",
     "-Wchar-subscripts",
     "-Wempty-body",
     "-Wextra",
@@ -68,7 +69,6 @@ DESIRABLE_WFLAGS = [
 ]
 
 UNDESIRABLE_WFLAGS = [
-    "-Wno-cast-qual", # GCC complains about musl::sched.h
     "-Wno-thread-safety", # Does not understand our mutexs are wrapped
     "-Wno-old-style-definition", # Does not like vgz
     "-Wno-sign-compare", # Fixable


More information about the varnish-commit mailing list