[master] 9db32058b Kill dead assert
Nils Goroll
nils.goroll at uplex.de
Tue Mar 3 12:27:40 UTC 2020
it's ok, but actually that bit _was_ intentional
On 03/03/2020 12:12, Dridi Boukelmoune wrote:
>
> commit 9db32058b4a98738dc26eded0cf5959719dc9fc1
> Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
> Date: Tue Mar 3 12:07:40 2020 +0100
>
> Kill dead assert
>
> The havemsg variable is purely local, and only written-then-read once.
>
> diff --git a/bin/varnishd/cache/cache_vcl.c b/bin/varnishd/cache/cache_vcl.c
> index 6064a9c08..0c8e221fb 100644
> --- a/bin/varnishd/cache/cache_vcl.c
> +++ b/bin/varnishd/cache/cache_vcl.c
> @@ -175,7 +175,7 @@ VCL_Rel_CliCtx(struct vrt_ctx **ctx)
> static int
> vcl_send_event(struct vcl *vcl, enum vcl_event_e ev, struct vsb **msg)
> {
> - int r, havemsg = 0;
> + int r, havemsg;
> unsigned method = 0;
> struct vrt_ctx *ctx;
>
> @@ -197,7 +197,7 @@ vcl_send_event(struct vcl *vcl, enum vcl_event_e ev, struct vsb **msg)
> method = VCL_MET_FINI;
> /* FALLTHROUGH */
> case VCL_EVENT_COLD:
> - AZ(havemsg);
> + havemsg = 0;
> break;
> default:
> WRONG("vcl_event");
> _______________________________________________
> varnish-commit mailing list
> varnish-commit at varnish-cache.org
> https://www.varnish-cache.org/lists/mailman/listinfo/varnish-commit
>
--
** * * UPLEX - Nils Goroll Systemoptimierung
Scheffelstraße 32
22301 Hamburg
tel +49 40 28805731
mob +49 170 2723133
fax +49 40 42949753
xmpp://slink@jabber.int.uplex.de/
http://uplex.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-commit/attachments/20200303/b98ded98/attachment-0001.bin>
More information about the varnish-commit
mailing list