[master] 1f5526a72 Coverity doesnt know that getaddrinfo only allocates res on success.
Poul-Henning Kamp
phk at FreeBSD.org
Thu May 9 06:04:10 UTC 2019
commit 1f5526a72e63d1d1db4f9a944f8b63ea386d0e6e
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date: Thu May 9 06:03:02 2019 +0000
Coverity doesnt know that getaddrinfo only allocates res on success.
diff --git a/lib/libvarnish/vss.c b/lib/libvarnish/vss.c
index 38c766203..0ad31a5b9 100644
--- a/lib/libvarnish/vss.c
+++ b/lib/libvarnish/vss.c
@@ -189,7 +189,7 @@ VSS_ResolveOne(void *dst, const char *addr, const char *port,
retval = VSA_Malloc(res->ai_addr, res->ai_addrlen);
else
retval = VSA_Build(dst, res->ai_addr, res->ai_addrlen);
- freeaddrinfo(res);
}
+ freeaddrinfo(res);
return (retval);
}
More information about the varnish-commit
mailing list