[master] f1584fd8d Partial revert of "Appropriate VSL group checking"
Dridi Boukelmoune
dridi.boukelmoune at gmail.com
Wed Jun 12 12:21:09 UTC 2019
commit f1584fd8d8e28308ef0c37af7b33aad947fcf50f
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date: Wed Jun 12 14:17:14 2019 +0200
Partial revert of "Appropriate VSL group checking"
This would trigger the tautological-compare warning on a recent-enough
Clang, and SunCC appears to complain as well.
Reported by @daghf.
diff --git a/lib/libvarnishapi/vsl_dispatch.c b/lib/libvarnishapi/vsl_dispatch.c
index b27646113..4bef6b233 100644
--- a/lib/libvarnishapi/vsl_dispatch.c
+++ b/lib/libvarnishapi/vsl_dispatch.c
@@ -1088,7 +1088,7 @@ VSLQ_New(struct VSL_data *vsl, struct VSL_cursor **cp,
struct VSLQ *vslq;
CHECK_OBJ_NOTNULL(vsl, VSL_MAGIC);
- if (grouping < 0 || grouping >= VSL_g__MAX) {
+ if (grouping >= VSL_g__MAX) {
(void)vsl_diag(vsl, "Illegal query grouping");
return (NULL);
}
More information about the varnish-commit
mailing list