[master] 691d5ac9b finally get r01490.vtc right
Nils Goroll
nils.goroll at uplex.de
Tue Apr 23 15:34:08 UTC 2019
commit 691d5ac9b3aaa4d22b98cc1ce44b8daa685f64e9
Author: Nils Goroll <nils.goroll at uplex.de>
Date: Tue Apr 23 17:26:54 2019 +0200
finally get r01490.vtc right
(i hope)
Trouble here is that in pool_herder(), we access pp->dry unprotected, so
we might see an old value, thus we might breed more than wthread_min
even if the dry condition does not exist any more.
So for the vtc, we need to wait until wthread_timeout has passed and the
surplus thread has been kissed to death.
Notice that this does not change with #2942 because there the same
unprotected access happens to lqueue.
diff --git a/bin/varnishtest/tests/r01490.vtc b/bin/varnishtest/tests/r01490.vtc
index 88c2550aa..fa7c8af67 100644
--- a/bin/varnishtest/tests/r01490.vtc
+++ b/bin/varnishtest/tests/r01490.vtc
@@ -13,7 +13,8 @@ varnish v1 \
-vcl+backend {}
varnish v1 -start
-delay 2
+# we might have over-bred
+delay 11
varnish v1 -expect threads == 2
More information about the varnish-commit
mailing list