[master] 1babec2d7 polish: avoid duplicate zero initialization

Nils Goroll nils.goroll at uplex.de
Mon Nov 12 15:24:12 UTC 2018


commit 1babec2d7ce65d05e2d1b35d9c9f6f5845732f66
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Mon Nov 12 16:19:35 2018 +0100

    polish: avoid duplicate zero initialization
    
    ALLOC_OBJ calls memset(0) already

diff --git a/lib/libvmod_blob/vmod_blob.c b/lib/libvmod_blob/vmod_blob.c
index 1b675abb2..06f29f664 100644
--- a/lib/libvmod_blob/vmod_blob.c
+++ b/lib/libvmod_blob/vmod_blob.c
@@ -199,15 +199,12 @@ vmod_blob__init(VRT_CTX, struct vmod_blob_blob **blobp, const char *vcl_name,
 	ALLOC_OBJ(b, VMOD_BLOB_MAGIC);
 	AN(b);
 	*blobp = b;
-	b->blob.free = NULL;
 	AZ(pthread_mutex_init(&b->lock, NULL));
 
 	len = decode_l(dec, strings);
-	if (len == 0) {
-		b->blob.len = 0;
-		b->blob.priv = NULL;
+	if (len == 0)
 		return;
-	}
+
 	assert(len > 0);
 
 	b->blob.priv = malloc(len);


More information about the varnish-commit mailing list