[master] fdc46c5 Explain why we don't clean up VSMW
Poul-Henning Kamp
phk at FreeBSD.org
Mon Jan 8 23:19:08 UTC 2018
commit fdc46c544a6e63c0fc5823e57428850a4b56dec0
Author: Charlie Root <root at critter.freebsd.dk>
Date: Mon Jan 8 08:20:58 2018 +0000
Explain why we don't clean up VSMW
diff --git a/bin/varnishd/mgt/mgt_child.c b/bin/varnishd/mgt/mgt_child.c
index 63fc3c3..8b70f1a 100644
--- a/bin/varnishd/mgt/mgt_child.c
+++ b/bin/varnishd/mgt/mgt_child.c
@@ -347,6 +347,12 @@ mgt_launch_child(struct cli *cli)
child_main(mgt_param.sigsegv_handler,
mgt_param.wthread_stacksize);
+ /*
+ * It would be natural to clean VSMW up here, but it is apt
+ * to fail in some scenarios because of the fall-back
+ * "rm -rf" in mgt_SHM_ChildDestroy() which is there to
+ * catch the cases were we don't get here.
+ */
// VSMW_Destroy(&heritage.proc_vsmw);
exit(0);
More information about the varnish-commit
mailing list