[5.2] 84ca575 VMOD blob: correct a special case in object finalization.

PÃ¥l Hermunn Johansen hermunn at varnish-software.com
Fri Sep 15 11:17:17 UTC 2017


commit 84ca5754fb86645a16d350b4425c9fe7e8433cd6
Author: Geoff Simmons <geoff at uplex.de>
Date:   Mon Sep 11 15:28:18 2017 +0200

    VMOD blob: correct a special case in object finalization.
    
    Don't attempt to free the static empty string that the VMOD assigns
    for empty encodings.

diff --git a/lib/libvmod_blob/vmod_blob.c b/lib/libvmod_blob/vmod_blob.c
index 20e44b7..6bb37ed 100644
--- a/lib/libvmod_blob/vmod_blob.c
+++ b/lib/libvmod_blob/vmod_blob.c
@@ -306,7 +306,7 @@ vmod_blob__fini(struct vmod_blob_blob **blobp)
 		b->blob.priv = NULL;
 	}
 	for (int i = 0; i < __MAX_ENCODING; i++)
-		if (b->encoding[i] != NULL && b->encoding[i][0] != '\0') {
+		if (b->encoding[i] != NULL && b->encoding[i] != empty) {
 			free(b->encoding[i]);
 			b->encoding[i] = NULL;
 		}


More information about the varnish-commit mailing list