[master] 98f3f95 Retire a misleading construct
Dridi Boukelmoune
dridi.boukelmoune at gmail.com
Sat Jan 28 01:19:04 CET 2017
commit 98f3f95341507bbd19494cf60433fe04de053449
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date: Sat Jan 28 01:12:44 2017 +0100
Retire a misleading construct
The port may not be hardcoded, it is still available for other processes
to steal during the race between `varnish v1 -stop` and the next `varnishd`
execution.
diff --git a/bin/varnishtest/tests/c00003.vtc b/bin/varnishtest/tests/c00003.vtc
index 1103129..52c1269 100644
--- a/bin/varnishtest/tests/c00003.vtc
+++ b/bin/varnishtest/tests/c00003.vtc
@@ -1,13 +1,9 @@
varnishtest "Check that we fail to start with erroneous -a/-b arguments"
-varnish v1 -vcl {
- backend dummy { .host = "${bad_backend}"; }
-} -start -stop
-
# Duplicate -a arguments
+# XXX: this cannot be tested reliably, we tolerate port collision
shell -err -match "have same address|already in use" {
- varnishd -d -a 127.0.0.1:${v1_port} -a 127.0.0.1:${v1_port} \
- -b localhost:80
+ varnishd -d -a 127.0.0.1:38484 -a 127.0.0.1:38484 -b localhost:80
}
# -a bad protocol specs
More information about the varnish-commit
mailing list