[master] ca42915 Always call va_end()

Federico G. Schwindt fgsch at lodoss.net
Wed Feb 1 04:10:05 CET 2017


commit ca42915cf8bd1b58424b3643d8ab8c04140c952b
Author: Federico G. Schwindt <fgsch at lodoss.net>
Date:   Wed Feb 1 02:45:48 2017 +0000

    Always call va_end()

diff --git a/lib/libvarnish/vsb.c b/lib/libvarnish/vsb.c
index bc72919..93fb65b 100644
--- a/lib/libvarnish/vsb.c
+++ b/lib/libvarnish/vsb.c
@@ -355,11 +355,11 @@ VSB_vprintf(struct vsb *s, const char *fmt, va_list ap)
 		va_copy(ap_copy, ap);
 		len = vsnprintf(&s->s_buf[s->s_len], VSB_FREESPACE(s) + 1,
 		    fmt, ap_copy);
+		va_end(ap_copy);
 		if (len < 0) {
 			s->s_error = errno;
 			return (-1);
 		}
-		va_end(ap_copy);
 	} while (len > VSB_FREESPACE(s) &&
 	    VSB_extend(s, len - VSB_FREESPACE(s)) == 0);
 



More information about the varnish-commit mailing list