[4.1] 7cd9826 At least one platform has a backtrace(3) which returns -1 in a size_t :-(

Lasse Karstensen lkarsten at varnish-software.com
Tue Jun 14 12:58:08 CEST 2016


commit 7cd98261f75676c02fc3109f649c082d00749839
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Sun May 29 20:27:09 2016 +0000

    At least one platform has a backtrace(3) which returns -1 in a size_t :-(

diff --git a/bin/varnishd/cache/cache_panic.c b/bin/varnishd/cache/cache_panic.c
index eb4aa2c..4951c51 100644
--- a/bin/varnishd/cache/cache_panic.c
+++ b/bin/varnishd/cache/cache_panic.c
@@ -418,14 +418,16 @@ static void
 pan_backtrace(struct vsb *vsb)
 {
 	void *array[10];
-	size_t size;
-	size_t i;
+	ssize_t size;
+	ssize_t i;
 	char **strings;
 	char *p;
 
 	size = backtrace (array, 10);
-	if (size == 0)
+	if (size <= 0) {
+		VSB_printf(vsb, "Backtrace not available (%zd)\n", size);
 		return;
+	}
 	VSB_printf(vsb, "Backtrace:\n");
 	VSB_indent(vsb, 2);
 	for (i = 0; i < size; i++) {



More information about the varnish-commit mailing list