[master] 52188d0 Default vcc_allow_inline_c to false in V4

Poul-Henning Kamp phk at varnish-cache.org
Mon Sep 23 21:10:24 CEST 2013


commit 52188d046988d23320560c27f8da0105e3bb673c
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Mon Sep 23 19:09:59 2013 +0000

    Default vcc_allow_inline_c to false in V4

diff --git a/bin/varnishd/mgt/mgt_param_tbl.c b/bin/varnishd/mgt/mgt_param_tbl.c
index 311abe9..6086c9c 100644
--- a/bin/varnishd/mgt/mgt_param_tbl.c
+++ b/bin/varnishd/mgt/mgt_param_tbl.c
@@ -522,7 +522,7 @@ const struct parspec mgt_parspec[] = {
 	{ "vcc_allow_inline_c", tweak_bool, &mgt_vcc_allow_inline_c, 0, 0,
 		"Allow inline C code in VCL.\n",
 		0,
-		"on", "bool" },
+		"off", "bool" },
 
 	{ "vcc_unsafe_path", tweak_bool, &mgt_vcc_unsafe_path, 0, 0,
 		"Allow '/' in vmod & include paths.\n"
diff --git a/bin/varnishtest/tests/c00052.vtc b/bin/varnishtest/tests/c00052.vtc
index 5de1430..2ab6c1a 100644
--- a/bin/varnishtest/tests/c00052.vtc
+++ b/bin/varnishtest/tests/c00052.vtc
@@ -7,7 +7,7 @@ server s1 {
 
 varnish v1 
 
-varnish v1 -cliok "param.show vcc_allow_inline_c"
+varnish v1 -cliok "param.set vcc_allow_inline_c true"
 
 varnish v1 -vcl+backend {
 	C{ getpid(); }C
diff --git a/bin/varnishtest/tests/c00055.vtc b/bin/varnishtest/tests/c00055.vtc
index ae98b48..ff13f66 100644
--- a/bin/varnishtest/tests/c00055.vtc
+++ b/bin/varnishtest/tests/c00055.vtc
@@ -10,7 +10,7 @@ server s1 {
 	txresp -status 200 -hdr "Foo: Foo" -body "56"
 } -start
 
-varnish v1 -vcl+backend {
+varnish v1 -cliok "param.set vcc_allow_inline_c true" -vcl+backend {
 	sub vcl_recv {
 		C{ VRT_CacheReqBody(ctx, 1000); }C
 		return (pass);
diff --git a/bin/varnishtest/tests/c00057.vtc b/bin/varnishtest/tests/c00057.vtc
index 5ac6cee..55c478e 100644
--- a/bin/varnishtest/tests/c00057.vtc
+++ b/bin/varnishtest/tests/c00057.vtc
@@ -5,7 +5,9 @@ server s1 {
 	txresp
 } -start
 
-varnish v1 -cliok "param.set sigsegv_handler on" -vcl+backend {
+varnish v1 -cliok "param.set vcc_allow_inline_c true"
+varnish v1 -cliok "param.set sigsegv_handler on"
+varnish v1 -vcl+backend {
 	C{
 #include <signal.h>
 #include <stdlib.h>
diff --git a/bin/varnishtest/tests/r00742.vtc b/bin/varnishtest/tests/r00742.vtc
index 9005fec..008f2f7 100644
--- a/bin/varnishtest/tests/r00742.vtc
+++ b/bin/varnishtest/tests/r00742.vtc
@@ -5,7 +5,7 @@ server s1 {
 	txresp
 } -start
 
-varnish v1 -vcl+backend {
+varnish v1 -cliok "param.set vcc_allow_inline_c true" -vcl+backend {
 	C{
 	void foo(void)
 	{
diff --git a/bin/varnishtest/tests/v00019.vtc b/bin/varnishtest/tests/v00019.vtc
index b8e5466..c4bd725 100644
--- a/bin/varnishtest/tests/v00019.vtc
+++ b/bin/varnishtest/tests/v00019.vtc
@@ -23,7 +23,7 @@ varnish v1 -errvcl {Unterminated string at} {
 	"
 }
 
-varnish v1 -vcl {
+varnish v1 -cliok "param.set vcc_allow_inline_c true" -vcl {
 	backend b { .host = "127.0.0.1"; }
 	sub vcl_recv { C{ int i; (void)i; }C }
 }
diff --git a/bin/varnishtest/tests/v00020.vtc b/bin/varnishtest/tests/v00020.vtc
index aac5776..2a98d30 100644
--- a/bin/varnishtest/tests/v00020.vtc
+++ b/bin/varnishtest/tests/v00020.vtc
@@ -1,6 +1,6 @@
 varnishtest "VCL compiler coverage test: vcc_parse.c & vcc_expr.c"
 
-varnish v1 -vcl {
+varnish v1 -cliok "param.set vcc_allow_inline_c true" -vcl {
 	backend b { .host = "127.0.0.1"; }
 	C{
 	#include <stdio.h>



More information about the varnish-commit mailing list