[master] 8e646cf Fix bug in smp_baninfo causing duplicate ban entries.

Martin Blix Grydeland martin at varnish-cache.org
Thu Dec 13 15:17:15 CET 2012


commit 8e646cfb1704ce63e1879642e002eb64854191d5
Author: Martin Blix Grydeland <martin at varnish-software.com>
Date:   Tue Nov 6 14:52:48 2012 +0100

    Fix bug in smp_baninfo causing duplicate ban entries.

diff --git a/bin/varnishd/storage/storage_persistent.c b/bin/varnishd/storage/storage_persistent.c
index 1efa24b..07ca29c 100644
--- a/bin/varnishd/storage/storage_persistent.c
+++ b/bin/varnishd/storage/storage_persistent.c
@@ -88,13 +88,12 @@ smp_baninfo(struct stevedore *stv, enum baninfo event,
 {
 	struct smp_sc *sc;
 
-	(void)stv;
+	CAST_OBJ_NOTNULL(sc, stv->priv, SMP_SC_MAGIC);
+
 	switch (event) {
 	case BI_NEW:
-		VTAILQ_FOREACH(sc, &silos, list) {
-			smp_appendban(sc, &sc->ban1, len, ban);
-			smp_appendban(sc, &sc->ban2, len, ban);
-		}
+		smp_appendban(sc, &sc->ban1, len, ban);
+		smp_appendban(sc, &sc->ban2, len, ban);
 		break;
 	default:
 		/* Ignored */



More information about the varnish-commit mailing list