r5177 - trunk/varnish-cache/lib/libvcl

phk at varnish-cache.org phk at varnish-cache.org
Wed Sep 8 09:23:31 CEST 2010


Author: phk
Date: 2010-09-08 09:23:31 +0200 (Wed, 08 Sep 2010)
New Revision: 5177

Modified:
   trunk/varnish-cache/lib/libvcl/vcc_vmod.c
Log:
Minor cleanups



Modified: trunk/varnish-cache/lib/libvcl/vcc_vmod.c
===================================================================
--- trunk/varnish-cache/lib/libvcl/vcc_vmod.c	2010-09-07 13:12:12 UTC (rev 5176)
+++ trunk/varnish-cache/lib/libvcl/vcc_vmod.c	2010-09-08 07:23:31 UTC (rev 5177)
@@ -76,12 +76,8 @@
 	Fi(tl, 0, "\t    &Vmod_Func_%.*s,\n", PF(mod));
 	Fi(tl, 0, "\t    sizeof(Vmod_Func_%.*s),\n", PF(mod));
 	Fi(tl, 0, "\t    \"%.*s\",\n", PF(mod));
-	if (fn != NULL) {
-		Fi(tl, 0, "\t    ");
-		EncString(tl->fi, fn, NULL, 0);
-	} else {
-		Fi(tl, 0, "\t    0");
-	}
+	Fi(tl, 0, "\t    ");
+	EncString(tl->fi, fn, NULL, 0);
 	Fi(tl, 0, ");\n");
 
 	/* XXX: zero the function pointer structure */
@@ -113,14 +109,14 @@
 	}
 
 	proto = dlsym(hdl, "Vmod_Proto");
-	if (modname == NULL) {
+	if (proto == NULL) {
 		vsb_printf(tl->sb, "Could not load module %.*s\n\t%s\n\t%s\n", 
 		    PF(mod), fn, "Symbol Vmod_Proto not found");
 		vcc_ErrWhere(tl, mod);
 		return;
 	}
 	spec = dlsym(hdl, "Vmod_Spec");
-	if (modname == NULL) {
+	if (spec == NULL) {
 		vsb_printf(tl->sb, "Could not load module %.*s\n\t%s\n\t%s\n", 
 		    PF(mod), fn, "Symbol Vmod_Spec not found");
 		vcc_ErrWhere(tl, mod);




More information about the varnish-commit mailing list