r4647 - trunk/varnish-cache/bin/varnishd

phk at varnish-cache.org phk at varnish-cache.org
Thu Apr 8 09:35:23 CEST 2010


Author: phk
Date: 2010-04-08 09:35:23 +0200 (Thu, 08 Apr 2010)
New Revision: 4647

Modified:
   trunk/varnish-cache/bin/varnishd/mgt_cli.c
Log:
After check reading the -S argument file during startup, we forgot to close
the file descriptor, but this causes no trouble apart from a wasted
filedescriptor in the parent process.

But closing it is better :-)

Fixes: 	#675
Spotted & Patch by:	Edmondas Girkantas


Modified: trunk/varnish-cache/bin/varnishd/mgt_cli.c
===================================================================
--- trunk/varnish-cache/bin/varnishd/mgt_cli.c	2010-04-07 13:26:30 UTC (rev 4646)
+++ trunk/varnish-cache/bin/varnishd/mgt_cli.c	2010-04-08 07:35:23 UTC (rev 4647)
@@ -517,6 +517,7 @@
 		fprintf(stderr, "Can not read secret-file \"%s\"\n", S_arg);
 		exit (2);
 	}
+	AZ(close(fd));
 	secret_file = S_arg;
 }
 




More information about the varnish-commit mailing list