[Varnish] #894: Missing errorhandling code in vep_do_include(), cache_esi_parse.c line 453:

[Varnish]

#894: Missing errorhandling code in vep_do_include(), cache_esi_parse.c line 453:
--------------------+-------------------------------------------------------
 Reporter:  perbu   |       Owner:       
     Type:  defect  |      Status:  new  
 Priority:  normal  |   Milestone:       
Component:  build   |     Version:  trunk
 Severity:  normal  |    Keywords:       
--------------------+-------------------------------------------------------
 Still on 3c8e5203ebd7ad232c80406511d4288a41a6fc87 ("Only do CRC
 calculation once.").

 Some bot came along and crashed varnish.

 {{{
 Last panic at: Sat, 02 Apr 2011 11:56:20 GMT
 Missing errorhandling code in vep_do_include(), cache_esi_parse.c line
 453:
   Condition((vep->include_src) == 0) not true.thread = (cache-worker)
 ident = Linux,2.6.32-30-generic,x86_64,-smalloc,-smalloc,-hcritbit,epoll
 Backtrace:
   0x42cd98: pan_ic+b8
   0x41e5d7: vep_do_include+47
   0x41e3a9: VEP_parse+ef9
   0x41c14b: vfp_esi_bytes+14b
   0x42223b: FetchBody+94b
   0x4164d8: cnt_fetchbody+418
   0x417a25: CNT_Session+315
   0x42e558: wrk_do_cnt_sess+b8
   0x42e9e1: wrk_thread_real+411
   0x7f99434d69ca: _end+7f9942e5e752
 sp = 0x7f993b129008 {
   fd = 11, id = 11, xid = 852536757,
   client = 95.108.241.252 52903,
   step = STP_FETCHBODY,
   handling = deliver,
   err_code = 200, err_reason = (null),
   restarts = 0, esi_level = 0
   ws = 0x7f993b129080 {
     id = "sess",
     {s,f,r,e} = {0x7f993b129cf0,+504,(nil),+65536},
   },
   http[req] = {
     ws = 0x7f993b129080[sess]
       "GET",
       "/trac/ticket/786?format=csv",
       "HTTP/1.1",
       "Host: www.varnish-cache.org",
       "Connection: Keep-Alive",
       "Accept: */*",
       "Accept-Language: ru, uk;q=0.8, be;q=0.8, en;q=0.7, *;q=0.01",
       "User-Agent: Mozilla/5.0 (compatible; YandexBot/3.0;
 +http://yandex.com/bots)",

       "From: support at search.yandex.ru",
       "X-Forwarded-For: 95.108.241.252, 95.108.241.252",
       "Accept-Encoding: gzip",
   },
   worker = 0x7f99342ebb70 {
     ws = 0x7f99342ebd10 {
       id = "wrk",
       {s,f,r,e} = {0x7f99342d9b00,+1768,(nil),+65536},
     },
     http[bereq] = {
       ws = 0x7f99342ebd10[wrk]
         "GET",
         "/trac/ticket/786?format=csv",
         "HTTP/1.1",
         "Host: www.varnish-cache.org",
         "Accept: */*",
         "Accept-Language: ru, uk;q=0.8, be;q=0.8, en;q=0.7, *;q=0.01",
         "User-Agent: Mozilla/5.0 (compatible; YandexBot/3.0;
 +http://yandex.com/bots)",
         "From: support at search.yandex.ru",
         "X-Forwarded-For: 95.108.241.252, 95.108.241.252",
         "X-Varnish: 852536757",
         "Accept-Encoding: gzip",
     },
     http[beresp] = {
       ws = 0x7f99342ebd10[wrk]
         "HTTP/1.1",
         "200",
         "Ok",

         "Date: Sat, 02 Apr 2011 11:56:16 GMT",
         "Server: Apache/2.2.14 (Ubuntu)",
         "Content-Disposition: filename=t786.csv",
         "Content-Length: 1121",
         "Content-Type: text/csv;charset=utf-8",
         "X-ESI: on",
     },
     },
     vcl = {
       srcname = {
         "input",
         "Default",
       },
     },
   obj = 0x7f9933907400 {
     xid = 852536757,
     ws = 0x7f9933907418 {
       id = "obj",
       {s,f,r,e} = {0x7f9933907618,+192,(nil),+248},
     },
     http[obj] = {
       ws = 0x7f9933907418[obj]
         "HTTP/1.1",
         "Ok",
         "Date: Sat, 02 Apr 2011 11:56:16 GMT",
         "Server: Apache/2.2.14 (Ubuntu)",
         "Content-Disposition: filename=t786.csv",
         "Content-Type: text/csv;charset=utf-8",
         "X-ESI: on",
     },
     len = 0,
     store = {
       0 {
       },
     },
   },
 },


 }}}

-- 
Ticket URL: <http://www.varnish-cache.org/trac/ticket/894>
Varnish <http://varnish-cache.org/>
The Varnish HTTP Accelerator